splitting Schema into a base class with a builder and factories - #3895
Merged
Conversation
sbiscigl
reviewed
Aug 13, 2026
sbiscigl
approved these changes
Aug 18, 2026
| // element boundaries). Aggregates hand control back through a consumer callback | ||
| // so nesting is expressed by re-entrancy rather than begin/end bookkeeping. | ||
| // | ||
| // smithy-java parameterizes the list/map consumers on a caller-supplied state |
Collaborator
There was a problem hiding this comment.
nit, lets not reference smithy-java directly in here, also in general lets get of overly verbose comments
| Aws::Schema::WriteQuotedJsonString(m_buf, value); | ||
| void WriteList(const Schema& /*schema*/, size_t, const std::function<void(ShapeSerializer&)>& consumer) override { | ||
| if (!OpenContainer('[')) { | ||
| return; |
Collaborator
There was a problem hiding this comment.
how does the caller know it error-ed?
| m_errorMessage = "Maximum nesting depth exceeded"; | ||
| return false; | ||
| SerializerOutcome GetPayload() { | ||
| if (m_finalized || !m_errorMessage.empty()) { |
Collaborator
There was a problem hiding this comment.
ohhhhhhh on get playload we return the error, i like that
pulimsr
marked this pull request as ready for review
August 18, 2026 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.